-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix version collection #5252
Merged
Merged
Fix version collection #5252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
FlorianVeaux
force-pushed
the
florian/fix_apache_version
branch
from
December 20, 2019 09:39
3984a7f
to
3f32b97
Compare
FlorianVeaux
force-pushed
the
florian/fix_apache_version
branch
from
December 20, 2019 10:06
3f32b97
to
81245e2
Compare
therve
requested changes
Dec 20, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments, looks good otherwise.
4 tasks
therve
approved these changes
Dec 20, 2019
@FlorianVeaux is it possible to patch this fix into the 6.16.x branch as well? |
@mattyo161 Yes working on it 👍 |
FlorianVeaux
added a commit
that referenced
this pull request
Dec 23, 2019
* Fix version collection * Address review
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apache version can be collected from three places:
A few notes:
This PR first fixes the behavior of the
_collect_metadata
method to prevent failing.It also tries to extract the version from the machine-readable output before falling back to the 'Status' header