Punch UDS / prometheus directly #909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 8, 2024
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
blt
force-pushed
the
blt/punch_uds___prometheus_directly
branch
2 times, most recently
from
b91e384
to
6ca1dc0
Compare
GeorgeHahn
approved these changes
Jul 8, 2024
Merged
blt
force-pushed
the
blt/punch_uds___prometheus_directly
branch
from
6cdd41e
to
6b25c79
Compare
blt
changed the base branch from
blt/allow_for_effectively_infinite_experiment_duration
to
blt/update_metrics-rs_crate
blt
force-pushed
the
blt/punch_uds___prometheus_directly
branch
from
6b25c79
to
842fbe1
Compare
blt
force-pushed
the
blt/update_metrics-rs_crate
branch
from
b76eaf3
to
eb0fc35
Compare
blt
force-pushed
the
blt/punch_uds___prometheus_directly
branch
from
842fbe1
to
02b03aa
Compare
blt
force-pushed
the
blt/update_metrics-rs_crate
branch
from
eb0fc35
to
9e7ce5c
Compare
blt
force-pushed
the
blt/punch_uds___prometheus_directly
branch
from
02b03aa
to
06003c4
Compare
blt
force-pushed
the
blt/punch_uds___prometheus_directly
branch
2 times, most recently
from
b79b650
to
60246e7
Compare
Merged
Demonstrated in https://github.com/scottopell/metrics/tree/sopell/uds-listener by @sopell it's entirely possible that upstream support for a UDS option is easier than I'd believed, looking at the TCP exporter. Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
Update tracks upstream changes, allows a run such like: ``` > cargo run --bin lading -- --target-path target/release/simple_target \ --config-path examples/lading-idle.yaml --experiment-duration-infinite \ --prometheus-path /tmp/lading.sock ``` `curl -vv --unix-socket /tmp/lading.sock http://localhost` returns a blank body, content-length 0. Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
blt
force-pushed
the
blt/punch_uds___prometheus_directly
branch
from
60246e7
to
10611ac
Compare
Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Demonstrated in https://github.com/scottopell/metrics/tree/sopell/uds-listener by @sopell it's entirely possible that upstream support for a UDS option is easier than I'd believed, looking at the TCP exporter.