Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Strip testing from published artifact #18

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

astuyve
Copy link
Contributor

@astuyve astuyve commented Mar 12, 2024

This should save about 200kB from the build

Before:

> npm pack
npm notice
npm notice 📦  pprof-format@2.0.4
npm notice === Tarball Contents ===
npm notice 555B    .github/ISSUE_TEMPLATE/bug_report.md
npm notice 119B    .github/ISSUE_TEMPLATE/feature_request.md
npm notice 573B    .github/workflows/ci.yml
npm notice 1.7kB   .github/workflows/codeql.yml
npm notice 582B    .github/workflows/package-size.yml
npm notice 352B    .github/workflows/pr-labels.yml
npm notice 714B    .github/workflows/release.yml
npm notice 329B    CONTRIBUTING.md
npm notice 1.1kB   LICENSE
npm notice 569B    LICENSE-3rdparty.csv
npm notice 147B    NOTICE
npm notice 2.1kB   README.md
npm notice 1.4kB   package.json
npm notice 40.4kB  testing/proto/profile.d.ts
npm notice 171.1kB testing/proto/profile.js
npm notice 9.5kB   testing/proto/profile.proto
npm notice 466B    testing/proto/README.md
npm notice 261.1kB testing/test.pprof
npm notice === Tarball Details ===
npm notice name:          pprof-format
npm notice version:       2.0.4
npm notice filename:      pprof-format-2.0.4.tgz
npm notice package size:  289.8 kB
npm notice unpacked size: 492.7 kB
npm notice shasum:        761106f11c223c1e65933f1394fbb0690fa339e9
npm notice integrity:     sha512-bp/OKhFnojk4b[...]WmRC5lprjwNwA==
npm notice total files:   18
npm notice
pprof-format-2.0.4.tgz

After:

> npm pack
npm notice
npm notice 📦  pprof-format@2.0.4
npm notice === Tarball Contents ===
npm notice 555B    .github/ISSUE_TEMPLATE/bug_report.md
npm notice 119B    .github/ISSUE_TEMPLATE/feature_request.md
npm notice 573B    .github/workflows/ci.yml
npm notice 1.7kB   .github/workflows/codeql.yml
npm notice 582B    .github/workflows/package-size.yml
npm notice 352B    .github/workflows/pr-labels.yml
npm notice 714B    .github/workflows/release.yml
npm notice 329B    CONTRIBUTING.md
npm notice 1.1kB   LICENSE
npm notice 569B    LICENSE-3rdparty.csv
npm notice 147B    NOTICE
npm notice 2.1kB   README.md
npm notice 1.4kB   package.json
npm notice 289.8kB pprof-format-2.0.4.tgz
npm notice === Tarball Details ===
npm notice name:          pprof-format
npm notice version:       2.0.4
npm notice filename:      pprof-format-2.0.4.tgz
npm notice package size:  295.8 kB
npm notice unpacked size: 300.0 kB
npm notice shasum:        c6d7419cb4dd898f80535c6bcf359ce471e16b77
npm notice integrity:     sha512-QnJW+cTCHaRtY[...]zR5VPxnoyglaA==
npm notice total files:   14
npm notice
pprof-format-2.0.4.tgz

@astuyve astuyve requested a review from Qard March 12, 2024 13:43
@astuyve astuyve added enhancement New feature or request semver-minor New feature additions labels Mar 12, 2024
@szegedi szegedi merged commit 06f7fdc into main Mar 20, 2024
12 of 14 checks passed
@szegedi szegedi deleted the aj/remove-testing-from-package branch March 20, 2024 17:28
This was referenced Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request semver-minor New feature additions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants