Remove support for node 14 #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overall package sizeSelf size: 7.41 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
BenchmarksBenchmark execution time: 2024-05-17 11:00:32 Comparing candidate commit d393231 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 31 unstable metrics. |
szegedi
reviewed
May 17, 2024
bindings/profilers/wall.hh
Outdated
| @@ -65,7 +65,7 @@ class WallProfiler : public Nan::ObjectWrap { | |||
| bool withContexts_ = false; | |||
| bool started_ = false; | |||
| bool workaroundV8Bug_; | |||
| bool detectV8Bug_; | |||
| bool detectV8Bug_ = true; | |||
There was a problem hiding this comment.
Do you want to keep this declared for code comprehension purposes? Presumably, the true value could just be inlined. Could also become a constexpr?
There was a problem hiding this comment.
That was indeed my intent !
I changed the code to make the member variable static constexpr.
Qard
previously approved these changes
May 17, 2024
nsavoire
force-pushed
the
nsavoire/remove_node14_support
branch
from
dd9afee
to
d393231
Compare
szegedi
approved these changes
May 17, 2024
szegedi
pushed a commit
that referenced
this pull request
Oct 22, 2024
szegedi
pushed a commit
that referenced
this pull request
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
Remove support for node 14