Add config to exclude function from Datadog #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add config to exclude functions from Datadog updates * Updated single to double quotes * Fix lint issues * Fix documentation Co-authored-by: Nick Holbrook <ndh175@gmail.com>
|
@hawkaa Thanks for your contribution and quick turnaround, I will review and test this week! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Basically the same as the excellent work done in #86 and #87, but includes a commit that deletes the DD_EXCLUDED_FUNCTIONS environment variable. Supersedes #90.
All credit to @nholbrook and @tianchu .
Motivation
Currently, there is no way to prevent Datadog from updating certain functions. One example of a scenario where this is a problem is when using this plugin with serverless-plugin-warmup. Datadog will update the handler of the warmer function created by this plugin, which prevents it from working.
Testing Guidelines
I added an additional test case and updated all associated test cases.
Additional Notes
This issue is documented here.
Types of changes
Check all that apply