Retain summary statistics when serializing/deserializing #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @hassy ! Thank you for the PR, and glad it's finding some use in Artillery! One thing that's not immediately obvious from this repo is that the protobuf definition is shared across our other language implementations of DDSketch (Java, Go). We will need to take those into account in thinking about how to land this, and plan to update those accordingly. |
|
That makes sense! Let me know if there's anything I can do to help land this change. We'll pin the dependency to our own fork for now for Artillery, but of course I'd love for this to be in the official distribution as soon as possible. :) |
hassy
added a commit
to artilleryio/artillery
that referenced
this pull request
Jul 29, 2021
Use our own fork of sketches-js until the PR is merged upstream: DataDog/sketches-js#13
hassy
added a commit
to artilleryio/artillery
that referenced
this pull request
Jul 29, 2021
Use our own fork of sketches-js until the PR is merged upstream: DataDog/sketches-js#13
hassy
added a commit
to artilleryio/artillery
that referenced
this pull request
Jul 29, 2021
Use our own fork of sketches-js until the PR is merged upstream: DataDog/sketches-js#13
hassy
added a commit
to artilleryio/artillery
that referenced
this pull request
Jul 29, 2021
Use our own fork of sketches-js until the PR is merged upstream: DataDog/sketches-js#13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in this PR fix
toProto/fromPrototo retain summary statistics (i.e.min,maxandsum).Thank you for a great library @brimtown!