Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby:Enable TestDynamicConfigSamplingRules in the next release #2361

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Apr 17, 2024

Changes

Dynamic configuration of trace sampling rules will be released in the next version of the Ruby tracer (DataDog/dd-trace-rb#3598).

This PR enables the relevant tests.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Relevant label (run-parametric-scenario, run-profiling-scenario...) are presents
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
    • To R&P team: locally build and push the image to hub.docker.com
  • A scenario is added (or removed)?
    • Get a review from R&P team
    • Once merged, add (or remove) it in system-test-dasboard nightly

@cbeauchesne
Copy link
Collaborator

So far, parametric tests are broken on ruby because of the rename ddtrace -> datadog. I'd be more confortable if we can fix that before merge anything.

@cbeauchesne
Copy link
Collaborator

Hi @marcotc , do you still plan to work on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants