[ruby19] backported Rails3 app to Ruby 1.9 #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palazzem
reviewed
Mar 16, 2017
ruby/rails/Gemfile
Outdated
|
|
||
| # tracing | ||
| gem 'ddtrace', '0.4.0' | ||
| gem 'ddtrace', '0.6.0' |
There was a problem hiding this comment.
can you point the repo to a stable commit? like:
gem 'ddtrace', :git => 'https://github.com/DataDog/dd-trace-rb', :ref => '0bd839d'(changing 0bd839d with the right one)
Actually this application is deployable and I can deploy it if it points to a right ddtrace gem. Also can you change the ruby version in the file? It's used to build the right Docker container for the deploy.
palazzem
approved these changes
Mar 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: ddtrace 0.6.0 is not fully out yet, but it's the number of the version that will have Ruby 1.9 support.