Update Ruby examples to latest versions #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delner
commented
Aug 14, 2018
| set_http_auth | ||
| end | ||
|
|
||
| def set_http_auth |
There was a problem hiding this comment.
These tests weren't working because they weren't setting authentication credentials. This fixes them to work with basic auth.
delner
commented
Aug 14, 2018
| @@ -0,0 +1 @@ | |||
| export DD_API_KEY=<Your Datadog API key here> | |||
There was a problem hiding this comment.
Added .envrc to allow users who use Direnv to setup their API key, without needing to modify code that's checked into Git.
delner
commented
Aug 14, 2018
|
|
||
| # queues | ||
| gem 'delayed_job_active_record' | ||
| gem 'daemons' | ||
|
|
||
| # testing | ||
| gem 'rails-controller-testing' |
There was a problem hiding this comment.
These gems were extracted from Rails 5 and need to be added.
delner
commented
Aug 14, 2018
| get '/' | ||
| end | ||
| end | ||
| # Currently broken in 0.0.7 of rails-perftest. |
There was a problem hiding this comment.
These tests don't work anymore, because rails-perftest has a bug in it that hasn't been fixed. We can enable this again whenever they get around to fixing it.
delner
force-pushed
the
delner/update_ruby
branch
4 times, most recently
from
6de2b58
to
d5f9f49
Compare
delner
force-pushed
the
delner/update_ruby
branch
from
d5f9f49
to
308137e
Compare
|
Ready for review now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our Ruby examples are out of date, showing Rails 3 apps. Let's update them to the latest Rails and
dd-trace-rbversion.