Laravel 4.2 sample app with both apache and nginx/fpm docker files #48
Conversation
|
This is a very good idea. The others required a little bit more work, so I took the shortcut 😄 but I want to do it because it makes a lot of sense. |
|
@pawelchcki I based the images on It would be great to have the final round of CR and merge it! |
|
|
||
| Start up an agent: you have to set the env `DATADOG_API_KEY` with your own DD api key. | ||
|
|
||
| $ docker-composer up -d agent |
There was a problem hiding this comment.
I make this type-o so often that I tweeted about it. 😆
| $ docker-compose build laravel42_php56_apache | ||
|
|
||
| # Php 5.6 - Nginx/fpm - Laravel 4.2 | ||
| $ docker-compose build laravel42_php56_nginx |
There was a problem hiding this comment.
I don't see the nginx config in the docker-compose.yml file. Should we remove the references to nginx? :)
There was a problem hiding this comment.
Right, to be removed, was there before. Good catch
| */ | ||
|
|
||
| Route::get('/', ['uses' => 'HomeController@showWelcome', 'as' => 'simple_route_name']); | ||
| Route::get('/distributed-tracing', 'HomeController@distributedTracing'); |
There was a problem hiding this comment.
I get an Apache-404 page when I try to visit this URL. I'm wondering if we're missing the Apache config for mod_rewrite? We should probably mention this route in the README, or was this just a left over test? :)
There was a problem hiding this comment.
Probably I left mod_rewrite config out when moving from the preconfigured image to the one based on php base images. Thanks for noticing. Looking at it
Add a docs line to hint the user at how the app can now been accessed Co-Authored-By: labbati <luca.abbati@datadoghq.com>
The very first commit is the Laravel application as created by the composer command in the getting started guide of the framework.
The real changes are here: dd05647...949eea7