Make generating NotScale events configurable; use logs when disabled #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
levan-m
previously approved these changes
Mar 11, 2024
|
The code LGTM but I don't think we should emit an event ever. Either we emit a debug log or we just update the |
clamoriniere
previously approved these changes
Mar 21, 2024
levipe01
dismissed stale reviews from clamoriniere, levan-m, and github-actions[bot]
via
832f671
levipe01
changed the title
levipe01
force-pushed
the
levipe01/notscale-events-config-option
branch
from
832f671
to
c8d2c1e
Compare
levipe01
changed the title
vboulineau
reviewed
Mar 22, 2024
| r.eventRecorder.Eventf(wpa, corev1.EventTypeNormal, datadoghqv1alpha1.ReasonNotScaling, fmt.Sprintf("Decided not to scale %s to %d (last scale time was %v )", reference, desiredReplicas, wpa.Status.LastScaleTime)) | ||
| if r.Options.SkipNotScalingEvents { | ||
| setCondition(wpa, autoscalingv2.ScalingActive, corev1.ConditionTrue, datadoghqv1alpha1.ConditionReasonNotScaling, "the WPA was able to successfully calculate a replica count and decided not to scale %s to %d (last scale time was %v )", reference, desiredReplicas, wpa.Status.LastScaleTime) | ||
| logger.Info(fmt.Sprintf("Decided not to scale %s to %d (last scale time was %v )", reference, desiredReplicas, wpa.Status.LastScaleTime)) |
There was a problem hiding this comment.
I think having the info once in the status is enough. The WPA is already a big logger, could be a debug log if you want to keep it.
vboulineau
approved these changes
Mar 22, 2024
levipe01
added a commit
that referenced
this pull request
Mar 22, 2024
…204) * Make generating NotScale events configurable; use logs when disabled * Adding status update along w/ log line * removed info level log line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add skipNotScalingEvents config option in WPA to disable NotScaling Kubernetes events. When disabled this will generate a log instead and update the
Statusof the WPA.Motivation
Eliminate WPA error logs that are the result of the Kubernetes API server rate limiting WPA event writes
Additional Notes
Statuswe use theScalingActiveCondition Type. This is initially set here and we override the condition & message to show that the replicas are correctly calculated, however we are choosing not to scale.Describe your test plan
Decided not to scaleto appear as logs instead.Statusupdate with a message like the below when not scaling.