npm installable javascript DJ client #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shangyian
approved these changes
May 1, 2023
|
Thanks @shangyian, updated the python builds to ignore the @agorajek or @betodealmeida not urgent but we should add the javascript jobs to be required checks for merging PRs. Also we have to setup a release job using an npm access token just like we did with pypi. I went ahead and published the |
youngman-droid
pushed a commit
to youngman-droid/dj
that referenced
this pull request
Aug 26, 2023
* npm installable javascript DJ client * remove test.html file * add javascript linters and build workflow * fix docs * Set javascript steps working-directory * add a step to install babel * npm install dev dependencies * working-dir * lint the github workflow definition * create a UMD hybrid module using webpack * no need to set lodash as external, not using * Set version to 0.0.1-rc.0 * Change docs example to list metrics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds an ES6 javascript DJ client that's npm installable. This PR only includes the get endpoints to pull entities but in a follow-up PR I'll add the ability to create entities as well.
update: I've restructured this a bit to use webpack with the type set as universal module definition (UMD) so we can use the single published npm package for both server side and client side javascript. (read more here)
Test Plan
N/A
make checkpassesmake testshows 100% unit test coverageDeployment Plan
N/A