Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tags to search #839

Merged
merged 5 commits into from
Oct 26, 2023
Merged

Add tags to search #839

merged 5 commits into from
Oct 26, 2023

Conversation

shangyian
Copy link
Contributor

Summary

Adds tags to the list of search entities.

Screen.Recording.2023-10-24.at.7.20.32.AM.mov

Test Plan

Locally

  • PR has an associated issue: #
  • make check passes
  • make test shows 100% unit test coverage

Deployment Plan

@netlify
Copy link

netlify bot commented Oct 24, 2023 •
edited
Loading

✅ Deploy Preview for thriving-cassata-78ae72 canceled.

Name Link
🔨 Latest commit 79a3b52
🔍 Latest deploy log https://app.netlify.com/sites/thriving-cassata-78ae72/deploys/6538a22b855b810008961acc

@shangyian shangyian marked this pull request as ready for review October 24, 2023 16:02
samredai
samredai approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@samredai samredai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! The Tag badge looks the same color (or very similar) to the red we use for the Metric badge. Could we use the color we have for the tag section on the node page? (I'm getting #E8E3EF for the background and #015C72 for the font color)
Screenshot 2023-10-24 at 8 23 30 PM

@shangyian shangyian merged commit 224d25a into DataJunction:main Oct 26, 2023
20 checks passed
@shangyian shangyian deleted the add-tags-to-search branch October 26, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samredai samredai samredai approved these changes

@agorajek agorajek Awaiting requested review from agorajek

@betodealmeida betodealmeida Awaiting requested review from betodealmeida

@CircArgs CircArgs Awaiting requested review from CircArgs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shangyian @samredai