Parity between column-level dimension links and node-level links #926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
agorajek
reviewed
Feb 27, 2024
| dimension_node, | ||
| [NodeType.CUBE], | ||
| ) | ||
| if affected_cubes: |
There was a problem hiding this comment.
If the previous line ends with or [] then this line may not be needed.
| @@ -78,6 +77,9 @@ def _join_path( | |||
| if col.dimension and col.dimension.type == NodeType.DIMENSION: | |||
| dimensions_to_columns[col.dimension.current].append(col) | |||
|
|
|||
| # for link in current_node.dimension_links: | |||
There was a problem hiding this comment.
forgot to uncomment or not needed?
There was a problem hiding this comment.
Oh yeah, this is no longer needed. Removed!
…ry key mapping (if any)
agorajek
approved these changes
Feb 28, 2024
shangyian
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR switches from column-level dimension links to node-level dimension links. The primary motivation for this switch is to make it so that the backend no longer needs to maintain two different storage mechanisms for dimension links -- there should just be a single storage mechanism via the
noderevision<-->dimensionlinktables.The changes cover the first bullet point in #927, and are primarily about reaching parity between the SQL generated via the column-level dimension links versus the node-level dimension links.
Test Plan
make checkpassesmake testshows 100% unit test coverageDeployment Plan