Switch to node-level dimension links #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
shangyian
force-pushed
the
switch-to-node-level
branch
2 times, most recently
from
852a99d
to
bcdec02
Compare
agorajek
approved these changes
Mar 5, 2024
| current_user=current_user, | ||
|
|
||
|
|
||
| @router.post("/nodes/{name}/migrate", status_code=201) # pragma: no cover |
There was a problem hiding this comment.
I know this is temporary, but it may feel safer to call if this endpoint is named clearer, e.g. migrate_dim_link.
There was a problem hiding this comment.
good point, renaming...
| ) | ||
| session.commit() | ||
| session.refresh(node) | ||
| return is_update |
There was a problem hiding this comment.
I am not sure this Boolean value is a useful return. I think returning nothing would be cleaner (like in remove_dimension_link), or returning an Enum (NEW, UPDATED, etc), but this true/false may just catch us by surprise somewhere.
There was a problem hiding this comment.
Makes sense! I think it's easier to just return an ActivityType enum, since we already have this enum for the history APIs. Let me make this change
8 tasks
shangyian
force-pushed
the
switch-to-node-level
branch
from
2db5348
to
e8be470
Compare
shangyian
force-pushed
the
switch-to-node-level
branch
from
e8be470
to
a1a873e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes the final switch over to node-level dimension links. It does so by:
Test Plan
Locally
make checkpassesmake testshows 100% unit test coverageDeployment Plan
ASAP. This blocks all other materialization-related changes. Once this PR has been merged, we also can't make new changes without deploying this migration successfully.