Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix filter pushdown + update node propagation #965

Merged
merged 2 commits into from
May 1, 2024
Merged

Fix filter pushdown + update node propagation #965

merged 2 commits into from
May 1, 2024

Conversation

shangyian
Copy link
Contributor

@shangyian shangyian commented Apr 21, 2024 •
edited
Loading

Summary

Fixes two bugs:

Test Plan

  • PR has an associated issue: #
  • make check passes
  • make test shows 100% unit test coverage

Deployment Plan

@netlify Netlify
Copy link

netlify bot commented Apr 21, 2024 •
edited
Loading

✅ Deploy Preview for thriving-cassata-78ae72 canceled.

Name Link
🔨 Latest commit e10c926
🔍 Latest deploy log https://app.netlify.com/sites/thriving-cassata-78ae72/deploys/6631d82abce6020008627245

@shangyian shangyian changed the title Fix intermittent bugs Fix filter pushdown + update node propagation Apr 21, 2024
@shangyian shangyian requested a review from agorajek April 21, 2024 18:00
@shangyian shangyian added the bug Something isn't working label Apr 21, 2024
@shangyian shangyian force-pushed the fix-intermittent-bugs branch 2 times, most recently from 996d1c6 to 89184a5 Compare April 21, 2024 18:45
@shangyian shangyian marked this pull request as ready for review April 27, 2024 06:58
agorajek
agorajek approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@agorajek agorajek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but a new or changed unit test could help reassure the fix.

@shangyian shangyian force-pushed the fix-intermittent-bugs branch 2 times, most recently from 6e44584 to 418fe90 Compare May 1, 2024 05:48
@shangyian
Copy link
Contributor Author

@agorajek Good point, I added tests for the two bugs

@shangyian shangyian merged commit 0f05019 into DataJunction:main May 1, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agorajek agorajek agorajek approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shangyian @agorajek