Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Total number of simulated particles missing? - frompattern #395

Open
kkorsgaard opened this issue May 18, 2021 · 0 comments
Open

Total number of simulated particles missing? - frompattern #395

kkorsgaard opened this issue May 18, 2021 · 0 comments
Assignees

Comments

@kkorsgaard
Copy link
Contributor

Possible issue/bug/improvement. Version 1.4.0 of pymchelper. SHIELDHIT12A V9.1

When using frompattern to load and combine many bdo files from different parallel simulations it returns an Estimator object. The Estimator object does include file_counter and number_of_primaries, but number_of_primaries just shows the dominated number of particles simulated, which in most of my cases is not the correct number for all files.

Goal – total number of simulated particles

I would like it to be possible to see the total number of particles simulated or different cases for number_of_primaries which includes how many files have these numbers :-)

approach to reproduce ‘bug’

Some simulations will due to set time limit not have time to finish and therefore less primaries simulated. The correct number of particles simulated is saved in the bdo file (using convertmc inspect), so the problem is that it cannot been seen after the bdo files are combined (I can’t find it at any rate).

Furthermore did I discover that that it is the dominated number and not the expected number of particles that the estimator object save as “number_of_primaries”. I did one simulation which in most cases did not have time to finish (400 000 particles) and as it saved (200 000) halfway and in the end the 200 000 was saved in the estimator object as “number of primaries”. This even though some files had 400 000 simulated particles. The number of files was 240 and also what was written in the field file_counter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants