Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure networking via env vars #51

Closed
2 tasks done
ThomasThelen opened this issue Nov 10, 2021 · 1 comment
Closed
2 tasks done

Configure networking via env vars #51

ThomasThelen opened this issue Nov 10, 2021 · 1 comment
Assignees
@ThomasThelen
Labels
enhancement New feature or request
Milestone
0.2.0

Comments

@ThomasThelen
Copy link
Member

ThomasThelen commented Nov 10, 2021 •
edited
Loading

We have a few deployment cases for slinky; at the moment we can configure these using an environment. In #43 I added a --prod flag to the cli which brings us further away from the pattern using environmental variables for this.

Instead, we should be able to configure the hosts in the kubernetes deployment file and the docker-compose definition.

This should involve

  • Add environmental variables/config map to the pods using d1lod
  • Modify d1lod to use networking variables from the environment, with sensible backups (probably local store settings)
@ThomasThelen ThomasThelen added the enhancement New feature or request label Nov 10, 2021
@ThomasThelen ThomasThelen self-assigned this Nov 10, 2021
@ThomasThelen ThomasThelen mentioned this issue Dec 2, 2021
Merged
11 tasks
@ThomasThelen ThomasThelen added this to the 0.2.0 milestone Dec 2, 2021
@amoeba
Copy link
Contributor

amoeba commented Feb 24, 2022

This was done by @ThomasThelen and merged to develop in #54.

@amoeba amoeba closed this as completed Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ThomasThelen ThomasThelen

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.2.0
Development

No branches or pull requests
2 participants
@amoeba @ThomasThelen