-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for v20 approved #722
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix typo
Fixed CF add back calc of disc ops , updated 135 to handle derivative assets and derivative liabilities.
Updated the rules to address extension elements in the calculation.
-- full run for approved v20-.0.0
- fix branch reference
- approved v20 with effective date
Now handles where values do not add and calc does not add an extension.
4 tasks
davidtauriello
added a commit
that referenced
this pull request
Feb 7, 2023
* Update for v20 approved (#722) * Updated to handle differences in subtotal in cash flows. * Update DQC_0043.xule * Updated rule 135 * Updated V20 for changes in rule 43 and updates to 135 for derivatives Fixed CF add back calc of disc ops , updated 135 to handle derivative assets and derivative liabilities. * Update DQC_0043.xule * Updated V20 for all changes for 135 and 43 * Updated 2023 taxonomy in V21 for changes * Updated rule 140 to address extensions Updated the rules to address extension elements in the calculation. * Updated version for V20 * Updated V20 * Update .travis.yml -- full run for approved v20.0.0 * Update resources.xule from CP xule.dqc - fix branch reference * Update rule submission forms - approved v20 with effective date * Updated rule 140 for 2021 and 2022 Now handles where values do not add and calc does not add an extension. * Update rule 140 for 2023 so can cherry pick seperately * Fixed 140 issue --------- Co-authored-by: Campbell * Update v20 approved - no logic changes (copyright, effective date) * Update rulesetMap.json * Update v20 Approved for merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Rules:
DQC_0142 - Typed Dimension Axis Restriction Restriction - This rule checks that the new typed dimensions to support Business Development Corporation (BDC) filings are defined correctly. The rule checks that each fact is associated with 1 typed dimension. Each fact should using a typed investment dimension, cannot use another explicit dimension. The only exception to the rule is the use of the explicit axis InvestmentCompanyNonconsolidatedSubsidiaryAxis, which was added as part of the BDC taxonomy upgrade.
DQC_0143 – Derivative Position Extensible Enumeration - This rule checks that the extensible enumeration element DerivativePositionExtensibleEnumeration can only use two values. The two allows values are:
DQC_0144 – No Balance Attribute in Financial Statements - This rule checks that extension monetary elements included in the balance sheet, income statement, cash flow statements and shareholders equity statements include a balance attribute. This is important so that data users have some idea what type of element the extension element is. If it is in the balance sheet then a credit is a liability or equity and if it is a debit then it is clear it is some kind of asset, thus allowing reasonable classification.
DQC_0145 – Inappropriate Cash Flow Presentation Presentation - This rule looks at the presentation linkbase of the cash flow statement and income statement to determine that elements have been presented correctly. The rule allows the following elements to be used in the presentation linkbase of the investing section of the cash flow statement:
The rule has three parts:
The first part of the rule determines the presentation children of the abstract concept representing financing items of NetCashProvidedByUsedInFinancingActivitiesAbstract. These concepts are then compared to the concepts not in the financing section of the us-gaap taxonomy defined by the FASB. If there is an intersection then these concepts are output as errors. This misclassification is a problem when trying to determine the financing items from the presentation linkbase.
The second part of the rule determines the presentation children of the abstract concept representing investing items of NetCashProvidedByUsedInInvestingActivitiesAbstract. These concepts are then compared to the concepts not in the investing section of the us-gaap taxonomy defined by the FASB. If there is an intersection then these concepts are output as errors. This misclassification is a problem when trying to determine the financing items from the presentation linkbase.
The third part of the rule identifies those elements defined as presentation descendants of IncreaseDecreaseInOperatingCapitalAbstract in the US-GAAP taxonomy defined by FASB. It then determines if any of these concepts are used in the income statement. In a number of instances filers are taking these elements and using them in the income statement incorrectly.
DQC_0146 – Incorrect Period Reported - This rule identifies incorrect period durations used in the income statement of the 10-K. The rule identifies where a company has reported a 10K but the majority of the values reported on the Income Statement are for a period other than a year. Although uncommon, this rule is provided to allow filers to detect if this situation has occurred.
DQC_0147 - Incorrect Sign of Elimination - This rule identifies when a filer enters a positive value for an element using the elimination member (on the consolidated items access) when it should be negative. The rule uses the same logic as used for the non negative rule (DQC_0015).
Rule DQC_0148 – OCI Items in Income - This rule identifies if OCI items have been included in the calculation of net income.
Updates:
DQC_0043 Incorrect Weights in Operating Cash Flows
This rule was expanded with an added suffix of .9875. The rule also checks that the sign of discontinued operations on the cashflow statement is the same as the sign on the income statement. In many cases companies were flipping the sign between the statements and using IncomeLossFromDiscontinuedOperationsNetOfTaxAttributableToReportingEntity for one value and IncomeLossFromDiscontinuedOperationsNetOfTax for the other value. The sign of these two elements should be the same if there is no noncontrolling interest.
This rule was expanded with an added suffix of .9873 that checks for a negative calculation between Net Income and Cash Flows from Operating Activities. Net Income should always make a positive contribution to cash from operations. In some cases companies were flipping the sign and the weight of Net Income.
DQC_0049 Single Calculation Tree for Changes in Cash Flows
Updated rule for the 2022 taxonomy to correctly identify root elements used inappropriately in the filers extension taxonomy. In 2022 the element CashAndCashEquivalentsPeriodIncreaseDecreaseExcludingExchangeRateEffect was deprecated. This deprecated element in the rule was updated with the element CashCashEquivalentsRestrictedCashAndRestrictedCashEquivalentsPeriodIncreaseDecreaseExcludingExchangeRateEffect
DQC_0118 Financial Statement Tables Calculation Check of Required Context
Updated the rule so that it would not run if the company had used the axis PledgedStatusAxis. The values for this axis should not be added together to get a balance sheet total.
DQC_0121 Incorrect Transition Elements Used
Updated the rule not to run for an 8-K or a 6-K.
DQC_0135 Extensible Enumeration for Financial Statement Captions
Updated rule to not run when broken down using the following axis:
Updated the message on the rule to indicate that the not disclosed flag can be used to clear an error. See update to the message below.
"If the filing does not disclose the financial statement captions where the amounts appear, an extension element {$NotDisclosedAsImmaterial} can be used. If this element is used, the rule will not produce an error."
The extension element must use the extensible enumeration value as a prefix.
DQC_0141 Inconsistent Accrued Interest Elements
Updated the rule to match accrued interest and excluding accrued interest to match by class. This means one class can include interest and another class can exclude interest as long as they are consistent between the classes of:
Pull request process
Once checklist is complete, @campbellpryde @marcward @davidtauriello please review for merge.