Release 2.0.0 #103
Merged
Release 2.0.0 #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiemowmde
force-pushed
the
release200
branch
2 times, most recently
from
a30e953
to
6465af3
Compare
|
Might want to consider #108 |
manicki
reviewed
May 8, 2017
README.md
Outdated
|
|
||
| * `GlobeCoordinateValue` does not accept empty strings as globes any more. | ||
| * `GlobeCoordinateValue` does not accept precisions outside the [-360..+360] interval any more. | ||
| * Changed hash calculation of `GlobeCoordinateValue` to be more robust. |
There was a problem hiding this comment.
Shouldn't this explicitly say the hash change was a backwards incompatible one? I know "robust" is supposed to mean it here but if does not immediately strike as a breaking change IMO.
JeroenDeDauw
reviewed
May 8, 2017
README.md
Outdated
| @@ -93,8 +93,11 @@ It is based upon and contains a lot of code written by [Jeroen De Dauw] | |||
|
|
|||
| ## Release notes | |||
|
|
|||
| ### 2.0.0 (dev) | |||
| ### 2.0.0 (2017-05-08) | |||
JeroenDeDauw
approved these changes
May 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please have a look at the 2.0.0 milestone. Because we changed a hash calculation in an incompatible way, we need to do a major version bump anyway. We might as well include all previously proposed breaking changes.