Better constructor order for Quantity[Html]Formatter #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brightbyte
pushed a commit
that referenced
this pull request
Sep 9, 2015
In preparation of merging pull/44
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is split from #44 to make it focused on the actual change it is about. Please note that both constructors already changed in #41. This already is a breaking change and needs a 0.6 release. This patch does not make this situation worse, it makes it better by moving the (basically non-optional) options parameter to the front, followed by the two sub-formatters, in #44 followed by the pattern that concatenates both.
Bug: T111186