Skip to content

Fix integer overflow in DecimalValue #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2016
Merged

Fix integer overflow in DecimalValue #70

merged 1 commit into from
Jul 11, 2016

Conversation

thiemowmde
Copy link
Contributor

This applies to int32 as well as int64 PHP versions.

@thiemowmde thiemowmde added the bug label Jul 11, 2016
@thiemowmde thiemowmde mentioned this pull request Jul 11, 2016
Merged
@brightbyte
Copy link

What exactly caused the overflow?

@thiemowmde
Copy link
Contributor Author

The line I fixed? $number === floor( $number ) is not a proper "can be converted to integer" check.

@brightbyte
Copy link

Ah, it's the line after the one you changed that actually overflows. I was confused about floor() having a problem with big numbers...

@brightbyte brightbyte merged commit a0bcd3c into master Jul 11, 2016
@brightbyte brightbyte deleted the int32Decimals branch July 11, 2016 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thiemowmde @brightbyte