Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cms] Feature - Save to PDF #1073

Merged
merged 52 commits into from
Sep 3, 2020
Merged

[cms] Feature - Save to PDF #1073

merged 52 commits into from
Sep 3, 2020

Conversation

jhmullen
Copy link
Collaborator

@jhmullen jhmullen commented Jul 23, 2020 •
edited by davelandry
Loading

Adds save to PDF feature to profile pages.

  • A new var called print is passed down through context from the top-level profile. It is true if ?print=true in the query.
  • The save button itself is in Hero.jsx, and is hidden in print mode in Hero.css.
  • The "Appendix" vizes are actually "real" vizes with a dataOnly flag. This flag skips rendering the viz, and simply "passes through" an Options.jsx datapanel of the data. That means we could theoretically use this anywhere if someone wanted a pure data-table "Visualization"

There is a Visible in PDF dropdown in the SectionEditor.jsx, currently hooked up to nothing, as I've not changed the DB yet. Once the design pass is done (cc @davelandry) I will return [i am jimdalf the white 🧙‍♂️ ] and make the changes necessary for a migration.

Closes #1075

@jhmullen jhmullen requested a review from davelandry July 23, 2020 18:09
@jhmullen jhmullen marked this pull request as draft July 23, 2020 18:09
davelandry
davelandry requested changes Aug 5, 2020
View reviewed changes
packages/cms/src/components/sections/Hero.jsx Outdated Show resolved Hide resolved
packages/cms/src/components/sections/Hero.jsx Outdated Show resolved Hide resolved
davelandry and others added 15 commits August 6, 2020 09:19
@davelandry
Merge branch 'master' into feature-1070-pdf
f1d96ca
@jhmullen
makes front-end pages store and respect dropdown states
0dc4ab7
@jhmullen
adds tab state to dropdown configuration
f17159c
@jhmullen
catches cases where panelIndex is out of range
c2f72eb
@jhmullen
bundles query state into pdf request
74066b6
@davelandry
creates exported PDFButton component
2f9b0e3
@davelandry
fixes pnpm-lock for examples logiclayet
6e7f127
@davelandry
resizes and styles puppeteer PDF
c4f7375
@davelandry
adds print to childcontext of ProfileRenderer and adds a cp-print class
ca3f0c5
@davelandry
offsets cp-hero-pdf top by nav-height
7744df3
@davelandry
only shows activeValue in Selector when print is true
7ff52fd
@davelandry
initial profile print styles
21b2f90
@davelandry
hides Subnav when print is true
324eb7b
@davelandry
hides Options when print is true
375f537
@davelandry
Merge branch 'feature-1070-pdf' of https://github.com/datawheel/canon …
af29391 
…into feature-1070-pdf
@davelandry davelandry linked an issue Aug 7, 2020 that may be closed by this pull request
[cms] maintaining front-end profile page state with query args #1075
Closed
2 tasks
@davelandry davelandry linked an issue Sep 1, 2020 that may be closed by this pull request
[cms] button to save profile as PDF #1070
Closed
6 tasks
@davelandry davelandry marked this pull request as ready for review September 3, 2020 17:10
@davelandry davelandry merged commit 56a2d0e into master Sep 3, 2020
@davelandry davelandry deleted the feature-1070-pdf branch September 3, 2020 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davelandry davelandry davelandry requested changes

Assignees

@jhmullen jhmullen

@davelandry davelandry

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[cms] maintaining front-end profile page state with query args [cms] button to save profile as PDF
2 participants
@jhmullen @davelandry