-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalid versions outside nixpkgs #567
Invalid versions outside nixpkgs #567
Conversation
Thanks for the quick merge David! (also note line 114 of mach_nix/requirements.py, where we explicitly take 'pytz>dev' to mean 'pytz', so any ol' version is being accepted.) |
only FYI: pyzmq # InvalidSpecifier: Invalid specifier: '!=3.0*' (e.g. from jupyter server )
|
Yeah, there a bunch of traps lying in the shift to PEP 440 enforcement that packing has handed us. If I'm reading the spec right, that should actually be '!=3.0.*' these days. More troubling is stuff like "openssl >=1.1.1l,<1.1.2a", (from conda), for which I currently don't have a good answer. |
Following #564, it was discovered that pypi is also full of no longer parsing versions.
We had 'fixed' this for nixpkgs in #549 by eliminating all non-parsable versions,
this does the same for pypi (sdist & wheel) and conda.
It's a hot take, and not the best way forward I suppose, but it does make master usable for now.