Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility for Weewx >= 4.10 #111

Closed
2 tasks done
Daveiano opened this issue Feb 2, 2023 Discussed in #110 · 2 comments
Closed
2 tasks done

Compatibility for Weewx >= 4.10 #111

Daveiano opened this issue Feb 2, 2023 Discussed in #110 · 2 comments
Labels
bug Something isn't working dependencies

Comments

@Daveiano
Copy link
Owner

Daveiano commented Feb 2, 2023

Discussed in #110

Originally posted by JonFear February 1, 2023
Hi!

Your favorite pain in the A**.

Applied the update from Weewx 4.9.1 to 4.10.1 and the skin has stopped working. I have Belchertown running in parallel and it is still working.

Any thoughts? Is there any log files I can copy for review?

Thanks

Jon

@Daveiano Daveiano added the bug Something isn't working label Feb 2, 2023
@Daveiano
Copy link
Owner Author

Daveiano commented Feb 2, 2023

The version comparison was removed because a simple string comparison is too flasky:

if weewx.__version__ < "4.6":
    raise weewx.UnsupportedFeature(
        "weewx 4.6 and newer is required, found %s" % weewx.__version__
    )

"4.10.0" is "smaller" than "4.6". This would need a more complex solution or the usage of a third-party package which is not the scope of the skin.

@Daveiano
Copy link
Owner Author

Daveiano commented Feb 2, 2023

Included in v2.3.3

@Daveiano Daveiano closed this as completed Feb 2, 2023
@Daveiano Daveiano changed the title Compatibility for Weewx > 4.10 Compatibility for Weewx >= 4.10 Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies
Projects
None yet
Development

No branches or pull requests

1 participant