Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode support #48

Closed
Supergamerx3000 opened this issue Aug 7, 2022 · 6 comments · Fixed by #57
Closed

Dark mode support #48

Supergamerx3000 opened this issue Aug 7, 2022 · 6 comments · Fixed by #57
Labels
Milestone

Comments

@Supergamerx3000
Copy link

Hello, will there be support for a dark mode in weewx-wdc?
Can you adjust the colors by hand so that the skin is displayed in the dark?

Kind regards
Pascal

@Daveiano Daveiano added enhancement New feature or request visuals labels Aug 7, 2022
@Daveiano
Copy link
Owner

Daveiano commented Aug 7, 2022

A dark mode is not yet supported but it would be a good addition to the skin!

Were you thinking about setting this via skin.conf (so the website is either in dark mode or in light mode), or providing a switch for the user like in the Belchertown skin (on the top right)?

@Daveiano
Copy link
Owner

Daveiano commented Aug 7, 2022

@Supergamerx3000 Sorry, I changed my answer after you reacted.

This was more of a question, but I tend to add a Light/Dark Switch like in the Belchertown skin

@Supergamerx3000
Copy link
Author

@Daveiano ah ok 😅 yes a light/dark switch sounds very good.
I'm looking forward to the feature 👍

@Daveiano Daveiano added this to the 2.1.0 milestone Aug 7, 2022
Daveiano added a commit that referenced this issue Aug 8, 2022
Daveiano added a commit that referenced this issue Aug 8, 2022
@Daveiano Daveiano modified the milestones: 2.1.0, 2.2.0 Aug 8, 2022
@Daveiano
Copy link
Owner

Daveiano commented Aug 9, 2022

Here is the state of the current dark-mode development, feedback is appreciated!

weewx-wdc-darkmode-gh-48

@Supergamerx3000
Copy link
Author

wow the dark mode already looks very good.

The only thing that bothers me is the red diagrams, which are very difficult to see (maybe it's just me because of my red/green weakness) can you put a slightly lighter color in there?

Otherwise, I can't see anything else that could be improved on the dark mode, the bar on the left is also dark and the server information below.

great work 👍

@Daveiano
Copy link
Owner

@Supergamerx3000 The red diagrams were indeed difficult to see, the contrast between the red lines and the dark background was too low. I desaturated these vibrant red colours for the dark theme.

The footer and the sidebar were actually not dark in the posted screenshots, this was on my to-do list. I updated this in the meantime and once this is released, these sections also will be dark.

Dark mode will hit in 2.2.0, I will close this issue for now. Feel free to open another one once this is out if there are any problems regarding the accessibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants