Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

75 support for combining different diagram types eg line and bar #109

Merged
merged 33 commits into from
Feb 26, 2023
Merged

75 support for combining different diagram types eg line and bar #109

merged 33 commits into from
Feb 26, 2023

Conversation

Daveiano
Copy link
Owner

@Daveiano Daveiano commented Feb 1, 2023

Fixes #75

@Daveiano Daveiano linked an issue Feb 1, 2023 that may be closed by this pull request
Support for combining different diagram types (eg. line and bar) #75
Closed
@Daveiano Daveiano added this to the 3.0.0 milestone Feb 1, 2023
@Daveiano Daveiano added documentation Improvements or additions to documentation needs tests labels Feb 1, 2023
@Daveiano
Tested curve.
5bc6f03
@Daveiano
Merge branch '3.x' into 75-support-for-combining-different-diagram-ty…
5b5ce73 
…pes-eg-line-and-bar
@Daveiano
Added curve handling to d3 charts.
582df98
@Daveiano
Updated test snapshots.
c2c00d9
@Daveiano
Added bar chart prototype via d3.
882abf7
@Daveiano
Experimented with interactivity.
f9f128c
@Daveiano
Experimental tooltip added.
a787895
@Daveiano
Updated diagram rendering: labels, axis, margins.
2721d97
@Daveiano
Started seperate d3 bar component.
c95d57c
@Daveiano
Seperated d3 bar component.
298cbe0
@Daveiano
Added combined tooltip for d3 line diagrams. Disabled FF useD3Diagram…
29b9844 
…s for testing.
@Daveiano
Added legends and optimized tooltips.
7c40a55
@Daveiano
Added fullscreen and markers to line.
f3b3854
@Daveiano
Updated markers. Added markers to bars. Updated combined chart.
4dffbab
@Daveiano
Disabled FF for testing.
1ed2eca
@Daveiano
Updated d3 diagrams - working first rc for combined chart.
1f745ee
@Daveiano
Fixed a bug in get_aggregate_interval for combined obs.
6186ee2
@Daveiano
Added feature flag for d3 charts in skin.conf. Support for enableCros…
ff27328 
…shair.
@Daveiano
Disabled FF for testing.
a053f7d
@Daveiano
Multi-unit support for line charts. Updated test snapshots.
19c0e53
@Daveiano Daveiano merged commit e00a75f into 3.x Feb 26, 2023
@Daveiano Daveiano deleted the 75-support-for-combining-different-diagram-types-eg-line-and-bar branch March 2, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation needs tests
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

Support for combining different diagram types (eg. line and bar)
1 participant
@Daveiano