windDir aggregation changed from avg to vecdir #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thank you very much for your contribution! I had a quick look over the test results and changes you made and things are looking good! Test fails are related to the changed windDir aggregate values - which was predictable |
|
@Jterrettaz Merging this would bump the WeeWX requirement to >= V4.9.0? This will throw an error with prior versions? |
|
yes, >= V4.9.0, or errors with previous versions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are my changes.
In summary : define a new aggregation type 'vecdir' for windDir in get_aggregate_type(), and add logic at some places to switch from 'windDir' to 'wind'.
Functionally, this replace windDir.avg to wind.vecdir