Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stat Tile: lightning_strike_count should show the sum #45

Merged
merged 1 commit into from
Aug 5, 2022
Merged

Stat Tile: lightning_strike_count should show the sum #45

merged 1 commit into from
Aug 5, 2022

Conversation

nifoc
Copy link
Contributor

@nifoc nifoc commented Aug 5, 2022

The lightning_strike_count stat tile currently shows the maximum for
the given range, which isn't optimal.

This PR changes the tile to behave like the rain or the ET tile.

The `lightning_strike_count` stat tile currently shows the maximum for
the given range, which isn't optimal.

This PR changes the tile to behave like the `rain` or the `ET` tile.
@Daveiano Daveiano added the enhancement New feature or request label Aug 5, 2022
@Daveiano Daveiano added this to the 2.1.0 milestone Aug 5, 2022
@Daveiano Daveiano merged commit 2a2961a into Daveiano:2.x Aug 5, 2022
@Daveiano
Copy link
Owner

Daveiano commented Aug 5, 2022

Thank you very much for your contribution!

My station does not provide the lightning_strike_count so I did not notice this. Happy to have this in now, thank you! I will include this in an upcoming 2.1.0 release.

@nifoc nifoc deleted the lightning_strike_count-stat-tile-max branch March 25, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants