Using the gettext function for "WeeWX version" in footer.inc #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the gettext function for "Weewx version" in footer.inc
hoetzgit
changed the title
|
Sieht doch gut aus! Das mit "with" geht nicht anders soweit ich weiß, ist schon korrekt so. |
Mir würden noch Möglichkeiten einfallen: Label bin ich mir nicht sicher, aber z.B.: WeeWX-Driver/Hardware, mit oder ohne "WeeWX-" oder wie jetzt kombiniert: u.s.w. |
|
Ich finde es so wie es jetzt durch deinen PR im Skin ist, gut! Weitere PRs nehme ich gerne entgegen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the gettext function for "WeeWX version" in footer.inc
Hab Nachsicht, mit "with" bin ich mir nicht sicher. Ist mein erster PR, aber man muss ja mal klein anfangen.