Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CMakeList.txt for esp-idf V5.1 #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

colincci
Copy link

@colincci colincci commented Mar 9, 2023

This has been tested against esp-idf v4.4 and v5.1

@DavidAntliff
Copy link
Owner

Thanks for the PR. Do you know if this works with earlier versions of the IDF?

@colincci
Copy link
Author

colincci commented Mar 13, 2023 via email

@DavidAntliff
Copy link
Owner

Hi Colin - thanks for offering, although I think it's better for the code that I advance this (and the other repositories you've submitted PRs to) to target IDF v4.4 or maybe v5.1 anyway.

Anyone using them with older versions of the IDF can continue to do so with the existing code. It's easier to maintain if I keep things moving forward...

When I find the time I'll update my IDF version support statement and merge this PR. Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants