Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow generics <TValue, TError> on ValueOrError type #56

Closed
wants to merge 4 commits into from
Closed

Allow generics <TValue, TError> on ValueOrError type #56

wants to merge 4 commits into from

Conversation

Odonno
Copy link
Contributor

@Odonno Odonno commented May 16, 2018

Linked to #48

It was relatively easy to make the change but I got mad with all these generics everywhere. :) Maybe there is a better way, for now I followed the easy one.

Also, I have 16 failed tests but not directly related to ValueOrError type. Not sure if it is my machine or if the tests are really broken.

@Odonno
Copy link
Contributor Author

Odonno commented May 17, 2018

Ok. Seems like 3 unit tests are broken due to JSON conversion. I will change that.

@Odonno
Copy link
Contributor Author

Odonno commented May 18, 2018

@DavidArno Well, I made the change on JSON serialization library but I needed to use reflexion methods only available on .NET Standard 2.0. So, it's a breaking change.

And I also need to add more unit tests.

@Odonno
Copy link
Contributor Author

Odonno commented Aug 24, 2019

Still pending.

@DavidArno
Copy link
Owner

It is indeed. I've been thrashing around with v4 of Succinct for months now. I have multiple branches, with multiple experiments with read-only structs and nullable reference types enabled, all in search of something I'm happy with.

With C# 8 due in the next month, I've created yet another branch and have started the whole process again. So v4 is planned for late September/early October when C# 8 goes live.

@Odonno
Copy link
Contributor Author

Odonno commented Aug 27, 2019

@DavidArno Good to know! Thank you for your dedicated work.

@Odonno Odonno closed this by deleting the head repository Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants