Disallow bad retry delay/jitter combination #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When stress testing #1, I noticed that it's possible for get_retry_timeout() to do something unexpected and throw an error. By disallowing retry_jitter >= retry_delay, and also changing the way get_retry_timeout() works, we avoid that possibility.
|
ping? |
ghost
marked this pull request as ready for review
|
bump? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When stress testing #1, I noticed that it's possible for
get_retry_timeout() to do something unexpected and throw an error. By
disallowing retry_jitter >= retry_delay, and also changing the way
get_retry_timeout() works, we avoid that possibility.