Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Phone port #9

Closed
ChaerilM opened this issue Oct 22, 2015 · 6 comments
Closed

Windows Phone port #9

ChaerilM opened this issue Oct 22, 2015 · 6 comments

Comments

@ChaerilM
Copy link
Contributor

I'd like to port this to windows phone, and probably over Store. should i make a pull request or do it using my own fork?.

regards.

@DavidFrahm
Copy link
Owner

Pull request would be great.

On Thursday, October 22, 2015, Chaeril M notifications@github.com wrote:

I'd like to port this to windows phone, and probably over Store. should i
make a pull request or do it using my own fork?.

regards.


Reply to this email directly or view it on GitHub
#9.

Cheers,
David Frahm
@DavidFrahm https://www.twitter.com/DavidFrahm

@ruisilva450
Copy link

What's the state of this?

@DavidFrahm
Copy link
Owner

No activity that I'm aware of. Ionic does support Windows Phone, so should be pretty straightforward for someone to submit a PR with the additional platform.

@ChaerilM
Copy link
Contributor Author

I Forgot :(, I used Resources from ios section for WP. and probably only that would get to PRed. since visual studio solutions tends to get confusing and messy. Should I add them as well?

@DavidFrahm
Copy link
Owner

@Zabanya I'm not clear on most of what you said, but you should open a PR and we'll work through it.

To me PRs are an invitation to a conversation, and shouldn't strive to be perfect when first created. That doesn't leave much room for iteration or collaboration :)

@DavidFrahm
Copy link
Owner

Windows support added via PR #10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants