Adds support to publish as scala.js library #4
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4 +/- ##
=======================================
Coverage 40.27% 40.27%
=======================================
Files 3 3
Lines 72 72
=======================================
Hits 29 29
Misses 43 43
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Looks perfect to me, I just have one question about the libraryDependencies. Thanks @Voltir!
| @@ -17,6 +19,9 @@ lazy val core = project.in(file("core")) | |||
| tutTargetDirectory := file(".") | |||
| ) | |||
|
|
|||
| lazy val coreJS = core.js | |||
| lazy val coreJVM = core.jvm | |||
|
|
|||
| lazy val commonSettings = Def.settings( | |||
There was a problem hiding this comment.
I don't really know a lot about how the Scala.js plugin works - do the libraryDependencies in the commonSettings need to use the %%% separator?
There was a problem hiding this comment.
You know, im not entirely sure. As far as I can tell, %%% wasn't needed, but maybe there is a runtime linker problem waiting to blow up if I use it more.
Im not entirely sure if this works with the publishSettings value you have to publish to sonatype, but
publishLocalworks.