Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jscs to version 3.0.0 🚀 #8

Closed
wants to merge 1 commit into from

Conversation

greenkeeperio-bot
Copy link
Contributor

Hello 👋

🚀🚀🚀

jscs just published its new version 3.0.0, which is not covered by your current version range.

If this pull request passes your tests you can publish your software with the latest version of jscs – otherwise use this branch to work on adaptions and fixes.

Happy fixing and merging 🌴


GitHub Release

Version 3.0.0 (2016-04-14):

Hell yeah! 3.0 is here. First and foremost we rewrote every... single... rule. We fixed a plentiful amount of bugs (most of which were found during refactoring those rules using CST). This provides us the opportunity to include autofix for complicated rules like the brand new disallowUnusedVariables rule (see below).

Breaking Changes

If you aren't a plugin writer or support build extensions (like grunt or gulp), etc you don't have to worry about anything.

We didn't rename any of the rules or remove any of the deprecated rule values; it is all still there. All you have to do to update is just bump the jscs version in your package version to 3.0.0 and be done with it.

One thing to notice though: the yandex preset was removed. Since Yandex doesn't have official code style (don't look at the https://github.com/ymaps/codestyle), we were requested to remove it

One drawback from all these changes is that JSCS might be a little, just a little slower, so if you find any issues related to that - don't hesitate to drop us a line, or just drop us a line we are all friendly :).

New rules

Since this release is about rewrite of internal design, we adding only four new rules (all of them were added by our contributors!).

disallowUnusedVariables by Brian Schemp

That rule useful when you have var x = <whatever> and you don't export that x and don't use it. This rule will highlight that and remove it if you want.

disallowSpacesInsideImportedObjectBraces and requireSpacesInsideImportedObjectBraces by Maks Sadowsky

When you need or don't need additional parentheses -

import /*–>*/{foo, bar}/*<–*/ from 'foo-bar';

requireUseStrict Erik Vold

Short and cool - ask you to use "use strict" pragma on top of the file if you so desire.

requireImportsAlphabetized by Ray Hammond

Keeps your imports alphabetized, pretty handy way to keep your dependency in tidy state.


The new version differs by 213 commits (ahead by 213, behind by 37).

  • c3a5e8a 3.0.0
  • 743dd8c Misc: add 3.0.0 changelog
  • 7cfe388 Tests: one last improvement to generator tests
  • e005fd3 Misc: make linters happy
  • a855828 Tests: remove unstable generator test and re-enable it
  • 86be5b5 Tests: skip the generator tests
  • 291bb41 Docs: remove leftover of yandex preset
  • 90fae1a [Perf] Reduce location computations
  • 4bd3800 [Fix] Parsing errors
  • 5b6f8de [Fix] Parsing errors
  • 4517263 [Fix] Keywords in identifiers
  • c82294f [Fix] Unskip generator tests
  • b09ef84 [Fix] Remaining style issues
  • 9ce5130 [Fix] JsDoc plugin dep
  • db5b76c [Fix] Error fixes

There are 213 commits in total. See the full diff.


This pull request was created by greenkeeper.io.
It keeps your software up to date, all the time.

Tired of seeing this sponsor message? Upgrade to the supporter plan! You'll also get your pull requests faster ⚡

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 19a857f on greenkeeper-jscs-3.0.0 into f398114 on master.

@DavidTPate DavidTPate self-assigned this Apr 15, 2016
@DavidTPate
Copy link
Owner

Closing in favor of #9

@DavidTPate DavidTPate closed this Apr 15, 2016
@DavidTPate DavidTPate deleted the greenkeeper-jscs-3.0.0 branch April 15, 2016 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants