Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate Illusion race #318

Closed
kevinlul opened this issue May 15, 2023 · 3 comments
Closed

Translate Illusion race #318

kevinlul opened this issue May 15, 2023 · 3 comments
Assignees
@kevinlul

Comments

@kevinlul
Copy link
Contributor

https://yugipedia.com/wiki/Illusion 幻想魔

Ensure undefined does not appear in the output text when the video game race icon is not available.

image

Further context: English is not affected. This problem was previously noted for Rush-exclusive races in #230

image
@kevinlul kevinlul mentioned this issue Jun 25, 2023
Closed
6 tasks
@kevinlul kevinlul assigned kevinlul and unassigned AlphaKretin Jul 8, 2023
@kevinlul
Copy link
Contributor Author

kevinlul commented Jul 8, 2023

Re undefined, it appears to be a bug in ttag when using the original locale, as native template strings should always show undefined. Potentially related: ttag-org/ttag#208

Creating POC to file issue.

@kevinlul
Copy link
Contributor Author

kevinlul commented Jul 8, 2023

Filed at ttag-org/ttag#262

kevinlul added a commit that referenced this issue Jul 8, 2023
@kevinlul
Fix missing race icons displaying as undefined in non-English locales
399041e 
#230 #318 ttag-org/ttag#262
@kevinlul
Copy link
Contributor Author

kevinlul commented Jul 8, 2023

Thank you @Ice-Pendragon for the Korean translation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevinlul kevinlul

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kevinlul @AlphaKretin