-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add /price command #167
Add /price command #167
Conversation
Based on YGOPRODeck implementation
Pull Request Test Coverage Report for Build 3117021257
💛 - Coveralls |
More accurate latency times, nomenclature improvements
oh and of course as this is merged, we have to add the price api url to the environment |
Now that I think of it, I actually don't think it needs to be there because this is tailored to a specific API and it was already in the open before: https://github.com/AlphaKretin/ygoprodeck-tag-bot/blob/master/config.json#L13 |
It doesn't need to be secret, but it's consistent with how we handle our other APIs/URLs. I would also object to hardcoding it in the command file, as it may be used later to add price data to card embeds. |
Wouldn't we move the entire |
...True. In that case, if that's how you want to do it I don't necessarily object, but I do lightly prefer the current state. |
Let's inline it. It's consistent with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 💸
Ported from https://github.com/AlphaKretin/ygoprodeck-tag-bot/blob/master/modules/price.ts
Closes #140.