Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete overhaul refactor of all Dialog sub classes #8

Closed
Daytron opened this issue Dec 18, 2014 · 0 comments
Closed

Complete overhaul refactor of all Dialog sub classes #8

Daytron opened this issue Dec 18, 2014 · 0 comments
Assignees
@Daytron
Labels
enhancement solved
Milestone
v2.0.0

Comments

@Daytron
Copy link
Owner

Daytron commented Dec 18, 2014

Refactor Dialog class as the master controller for all fxml dialog views. A new argument can be added as a parameter to determine what type of dialog is to be produced, this dictates what fxml file to load by the FxmlLoader.

This elimates the extra need to create extra sub-classes.
@Daytron Daytron self-assigned this Dec 18, 2014
@Daytron Daytron added this to the 1.5.0 milestone Dec 18, 2014
@Daytron Daytron mentioned this issue Dec 18, 2014
Closed
Daytron pushed a commit that referenced this issue Dec 18, 2014
Overhaul refactor of the Dialog class and removal of redundant Dialog…
7821fcd 
… sub classes, fix issue #8
@Daytron Daytron added the solved label Dec 18, 2014
@Daytron Daytron closed this as completed Dec 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Daytron Daytron

Labels
enhancement solved
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
1 participant
@Daytron