Add <link> for OpenSearch autodiscovery #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although opensearch.xml was already defined, browsers wouldn't find it because it wasn't linked from the HTML pages as described in [Autodiscovery in HTML/XHTML]. This commit adds the necessary <link> elements to the search and results pages. [Autodiscovery in HTML/XHTML]: https://github.com/dewitt/opensearch/blob/c9ed38a/opensearch-1-1-draft-6.md#autodiscovery-in-htmlxhtml Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
stapelberg
approved these changes
Jun 1, 2020
|
Thanks! This is now deployed |
|
Thanks for the lightning-fast review, merge, and deploy! I just added DCS to Firefox using autodiscovery, and it worked like a charm. |
|
Great, thanks for confirming :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Great project! I was hoping to add it to my Firefox search engines, but, although
opensearch.xmlis available, my browser couldn't find it because it isn't linked from the HTML pages as described in OpenSearch Autodiscovery in HTML/XHTML. This PR adds the necessary<link>element to the search and results pages.Thanks for considering,
Kevin
P.S. It also fixes a small typo I noticed. If you'd prefer that commit be submitted separately, let me know.