Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(appbars): fix spacing issue between searchView and left icon #172

Merged
merged 1 commit into from
Mar 30, 2023
Merged

fix(appbars): fix spacing issue between searchView and left icon #172

merged 1 commit into from
Mar 30, 2023

Conversation

FDELAHA24
Copy link
Contributor

@FDELAHA24 FDELAHA24 commented Mar 17, 2023 •
edited by ManonPolle
Loading

Changes description

Remove spacing between left icon and search view

Context

Closes #146

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch. Please, don't request directly from your main!
  • Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
  • Check your code additions will fail neither code linting checks.
  • I have reviewed the submitted code.
  • I have tested on a phone device/emulator.
  • I have tested on a tablet device/emulator.
  • I have tested on a large screen device/emulator.
  • If it includes design changes, please ask for a review design-system-core-team-design GitHub team.

Does this introduce a breaking change?

  • No

Screenshots

Phone

Screenshot_20230317_160443

Tablet

Large screen

Other information

@FDELAHA24 FDELAHA24 requested review from ManonPolle and a team as code owners March 17, 2023 15:15
@FDELAHA24 FDELAHA24 requested a review from a team March 17, 2023 15:16
@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/62ac2962b2dd627a/build/15dbd0b0-0896-4234-a68d-9b6b9b0e49ab/artifact/658785001848abdf/p/e0621d0ed7a3c99363a7a5e8c9aeae3f

@lauthieb lauthieb linked an issue Mar 20, 2023 that may be closed by this pull request
bug: Remove extra spacing when using topAppBar embedded searchView #146
Closed
@lauthieb lauthieb added bug 🐛 Something isn't working run 💨 labels Mar 20, 2023
@ManonPolle ManonPolle force-pushed the fix/topAppBar_searchView_spacing branch from 235c20d to b2866df Compare March 23, 2023 15:41
@sonarcloud
Copy link

sonarcloud bot commented Mar 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/62ac2962b2dd627a/build/bc7e12d9-e4e6-45cf-9b97-aee9d801c340/artifact/61cafd9841a6cb74/p/cf481469f1414a4cbf521450eebc804a

@ManonPolle ManonPolle merged commit f4673be into Decathlon:main Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonLeclercq SimonLeclercq SimonLeclercq approved these changes

@ManonPolle ManonPolle ManonPolle approved these changes

Assignees

@FDELAHA24 FDELAHA24

Labels
bug 🐛 Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Remove extra spacing when using topAppBar embedded searchView
5 participants
@FDELAHA24 @dktbitrise @ManonPolle @SimonLeclercq @lauthieb