Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix typos #60

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ uniswap-callback-not-protected | Generic | Uniswap callback is not protected
encode-packed-collision | Generic | Hash collision with variable length arguments in abi.encodePacked
openzeppelin-ecdsa-recover-malleable | OpenZeppelin | Potential signature malleability
BETA: basic-arithmetic-underflow | Umbrella Network, Remittance Token | Possible arithmetic underflow
unrestricted-transferownership | Ragnarok Online Invasion | Contract ownership can be transfered by anyone
unrestricted-transferownership | Ragnarok Online Invasion | Contract ownership can be transferred by anyone
msg-value-multicall | Sushiswap | Function with constant msg.value can be called multiple times
no-bidi-characters | Generic | The code must not contain any of Unicode Direction Control Characters
delegatecall-to-arbitrary-address | Generic | An attacker may perform delegatecall() to an arbitrary address.
Expand Down Expand Up @@ -151,7 +151,7 @@ use-nested-if | Using nested is cheaper than using && multiple check combination
use-prefix-decrement-not-postfix | The prefix decrement expression is cheaper in terms of gas.
use-prefix-increment-not-postfix | The prefix increment expression is cheaper in terms of gas.
use-short-revert-string | Shortening revert strings to fit in 32 bytes will decrease gas costs for deployment and gas costs when the revert condition has been met.
non-payable-constructor | Consider making costructor payable to save gas.
non-payable-constructor | Consider making constructor payable to save gas.
non-optimal-variables-swap | Consider swapping variables using `($VAR1, $VAR2) = ($VAR2, $VAR1)` to save gas.
inefficient-state-variable-increment | <x> += <y> costs more gas than <x> = <x> + <y> for state variables.

Expand Down
2 changes: 1 addition & 1 deletion solidity/security/erc20-public-burn.sol
Original file line number Diff line number Diff line change
Expand Up @@ -1480,7 +1480,7 @@ contract Hospo is ERC20, Ownable {
_isExcludedFromFees[presaleAddress] = true;
}

// call this function once liquiidity is added
// call this function once liquidity is added
function startTrading() external onlyOwner {
buyFee.devFee = 35;
buyFee.liquidityFee = 10;
Expand Down
4 changes: 2 additions & 2 deletions solidity/security/sense-missing-oracle-access-control.sol
Original file line number Diff line number Diff line change
Expand Up @@ -422,10 +422,10 @@ contract Space is IMinimalSwapInfoPool, BalancerPoolToken, PoolPriceOracle {
// Disambiguate requested amounts wrt token type
(uint256 reqPTIn, uint256 reqTargetIn) = (reqAmountsIn[pti], reqAmountsIn[1 - pti]);
uint256 _totalSupply = totalSupply();
// Caclulate the percentage of the pool we'd get if we pulled all of the requested Target in
// Calculate the percentage of the pool we'd get if we pulled all of the requested Target in
uint256 bptToMintTarget = BasicMath.mul(_totalSupply, reqTargetIn) / targetReserves;

// Caclulate the percentage of the pool we'd get if we pulled all of the requested PT in
// Calculate the percentage of the pool we'd get if we pulled all of the requested PT in
uint256 bptToMintPT = BasicMath.mul(_totalSupply, reqPTIn) / pTReserves;

// Determine which amountIn is our limiting factor
Expand Down
4 changes: 2 additions & 2 deletions solidity/security/thirdweb-vulnerability.sol
Original file line number Diff line number Diff line change
Expand Up @@ -64,10 +64,10 @@ contract TokenERC20 is
/// @dev The % of primary sales collected by the contract as fees.
uint128 private platformFeeBps;

/// @dev The adress that receives all primary sales value.
/// @dev The address that receives all primary sales value.
address internal platformFeeRecipient;

/// @dev The adress that receives all primary sales value.
/// @dev The address that receives all primary sales value.
address public primarySaleRecipient;

/// @dev Mapping from mint request UID => whether the mint request is processed.
Expand Down
2 changes: 1 addition & 1 deletion solidity/security/unrestricted-transferownership.sol
Original file line number Diff line number Diff line change
Expand Up @@ -1175,7 +1175,7 @@ contract ROIToken is Context, IERC20, Ownable {
uniswapV2Router = _uniswapV2Router;
}

// To recieve ETH from uniswapV2Router when swapping
// To receive ETH from uniswapV2Router when swapping
receive() external payable {}


Expand Down