Better install docs, better config.cfg readability; update zkSessionTimeout to 20 #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apurvis
changed the title
This was referenced Jun 20, 2017
jlrigau
reviewed
Jun 20, 2017
config.cfg
Outdated
| @@ -40,7 +40,7 @@ sessionTimeout=300 | |||
|
|
|||
| #Default 5 seconds to keep short lived zk sessions. If you have large data then the read will take more than 30 seconds so increase this accordingly. | |||
There was a problem hiding this comment.
Comment should be updated according to the new default value
| 3. Run the jar. ( nohup java -jar zkui-2.0-SNAPSHOT-jar-with-dependencies.jar & ) | ||
| 4. <a href="http://localhost:9090">http://localhost:9090</a> | ||
| 1. `git clone https://github.com/DeemOpen/zkui.git` | ||
| 2. `cd zkui` |
There was a problem hiding this comment.
I am not convinced by the need of having this level of detail for the setup.
There was a problem hiding this comment.
so instead of directions you can copy/paste straight into a terminal window, you'd rather have vague, imprecise directions?
There was a problem hiding this comment.
It is much easier to follow updated instructions so 👍 for this PR.
There was a problem hiding this comment.
In this case a shell script or a Makefile may be a suitable option?
There was a problem hiding this comment.
it might be. feel free to update them after merging or closing this PR.
|
are you going to merge or close this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@arjunsurendra04 @jlrigau