Add phpstan-return annotation to translateText #41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @daniel-jones-deepl,
When using static analysis tool like PHPStan or Psalm, it is possible to explain that the return type of
translateText
Cf https://phpstan.org/blog/phpstan-1-6-0-with-conditional-return-types#conditional-return-types
This would be helpful to help the tool understanding better the result type and avoid useless extra checks.