9th July 2020

Meeting 09/07/2020

Agenda

Presentation: N/A
Chair: Yipeng Hu
Minutes: Alex Grimwood
Attendance:
Yipeng HY
Nina Montana Brown NMB
Yunguan Fu YF
Remi Delaunay RD
Ester Bonmati EB
Adria Casamitjana AC
Zac Baum ZB
Qianye Yang QY
Zhe Min ZM
Shaheer Saeed SS
Matt Clarkson MC (apologies for joining late)

Updates and next tasks

Who?	Discussion Points	Next
Dean Barratt	N/A	N/A
Zac Baum	Review/Merging PR Best Practices Unit testing	More unit testing
Ester Bonmati Coll	Readme Data storage possibilities Testing for demos	Build demo
Adria Casamitjana		Build demo (use dvf) Testing: DVF and unpaired loader
Matt Clarkson
Remi Delaunay		Unit testing Affine network
Yunguan Fu		Build demo to evaluate ddf/dvf/cond
Alex Grimwood
Yipeng Hu	Demos Core Dev Team/maintainers post R1 Timeline to R1
Nina Montana Brown	Gauge time commitments from QA contributors Unit Testing timeline MICCAI Educational Challenge? CoC review + decision on how to action in case of issues.	Assign remaining unit test tickets More tests Investigate Gitter PR merge/vs rebase, discuss.
Saeed Shaheer	How to manage learn2reg t1 demo files	Add additional unit tests for h5 loader Add new loader tutorial
Qianye Yang

Open Questions

Nina: Check-in transition into GitHub with team, contribution styles ok? Final docs run/consistency for doc delivery.

Minutes

DeepReg Background:
Publishing in Journal of Open Source Software (JOSS) suggested by Tom to ensure DeepReg is developed to a opensource standards.
NMB responsible for quality, docs and testing.
DeepReg is in early development stages, formulating demos and identifying bugs etc.
Intention is to form a core development team. Requires substantial commitment (2-3 hours per week over the course of the next few months). Other volunteer opportunities will exist.

Today's Agenda & general Discussion:
https://docs.google.com/document/d/1yLFSAHEFlnbnDVyGYlSt3dBdLynNxGrrl9oxuHapHHY/edit

By default all people on the call will be considered part of core development team.
The goal for today is to discuss demos

Wiki contains minimum requirements for Demos:
https://github.com/ucl-candi/DeepReg/wiki/Demo-minimum-requirement
e.g. clear documentation, open source data, simple layout etc.

Queries or questions from dev team should be raised as issues on github - remember to tag people!

Label any commits to demos with the deepreg version. This is a stopgap until more formal versioning is implemented. Demos will not be unit-tested, so care must be taken to meet wiki requirements.

Preprocessing and other features should only be included in the demo scripts if they are simple. More involved processing steps should be handled outside of the demo script.

EB: is there a common standard for demo libraries and visualisation paradigms, etc?
YH: stick to simple libs and visualisations using modules contained within core build: e.g. matplotlib
EB: urges minimum testing standards for demos even if unit testing is not required

Help is required to write a showcase demo (NMB)

Target Dates:
End of July-beginning of August is targeted initial release date.

Unit Testing:
Everyone encouraged to volunteer for unit testing
NMB and ZB are moving onto more advanced tests
(~ 30 - 40 hours of tests still need to be written)
All tickets raised, anyone can assign themselves
Code of conduct has been written, but requires finalising - please review and provide feedback: (https://github.com/ucl-candi/DeepReg/blob/master/docs/CODE_OF_CONDUCT.md)
Come join the unit testing team!

General communications:
YF: Raise issues on Github, but make sure to tag people so they receive notifications!
YF: If anything is not clear for demo development etc. raise an issue and tag
Consensus suggestion to transfer group chat to gitter (other options, teams or slack).

Responisbilities:
NM testing & docs
YF YH analytics & development
SS YG TH loaders
RD, AC, QY have experience of deep registration code - hard science
MC also offers scientific support

YH & YF suggest documentation should be structured into seperate categories: tutorials and technical docs
All are encouraged to review docs for readability and to raise tickets where necessary.

Merging and Versioning:
ZB: what is good merging best practice? Especially surrounding merge-commits and commit messages
ZB: suggests stop merging and move to squashing and rebasing
squashing and rebasing is collecting many commits into a single (squashed) version, which can be rebased in one shot.
MC: argues against rebasing at merge to master.

Wrap up: NMB has 6 volunteers for testing: AG, DR, ZB, Zhemincuhk, AC, QY, SS Urges all to self-assign for ~ 1hr per week.

EB: 650 MB limit for hosting demo data on github YH: offers to create a UCL repo if needed, also suggests: kaggle, google drive, onedrive

meeting will be held weekly, with loose agenda to be kepy under 1hr.