Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign windows executable #478

Merged
merged 10 commits into from
Jul 2, 2024
Merged

Sign windows executable #478

merged 10 commits into from
Jul 2, 2024

Conversation

lionello
Copy link
Member

@lionello lionello commented Jun 18, 2024

Fixes #12

Reqs:

  • MacOS: codesign an notarytool
  • Windows: signtool using action
  • Nix: nix-prefetch-url (required during the release step)

@lionello lionello changed the title wip Sign windows executable Jun 18, 2024
@lionello lionello force-pushed the lio-sign-windows branch 2 times, most recently from 821a642 to ddb3854 Compare June 27, 2024 20:50
@lionello lionello marked this pull request as ready for review June 30, 2024 18:35
@lionello
Copy link
Member Author

lionello commented Jun 30, 2024

FYI, GoReleaser now supports MacOS signing and notarization (which would replace the shell scripts we currently use and allow us to build on any OS, not just Mac): https://goreleaser.com/customization/notarize/

#517

Copy link
Contributor

@edwardrf edwardrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lionello lionello merged commit 490c862 into main Jul 2, 2024
7 checks passed
@lionello lionello deleted the lio-sign-windows branch July 2, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sign Windows CLI executable
2 participants