Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap ptvsd for debugpy, ptvsd deprecated #4115

Closed
madchap opened this issue Mar 24, 2021 · 2 comments
Closed

Swap ptvsd for debugpy, ptvsd deprecated #4115

madchap opened this issue Mar 24, 2021 · 2 comments
Labels
enhancement

Comments

@madchap
Copy link
Contributor

madchap commented Mar 24, 2021

As mentioned by @ptrovatelli at https://owasp.slack.com/archives/C014H3ZV9U6/p1616534386011200

so it seems that ptvsd is deprecated, replaced by debugpy (see https://github.com/microsoft/ptvsd ). ptvsd is what we use for debugging with docker.
@yilmi yilmi mentioned this issue Apr 20, 2021
Merged
valentijnscholten pushed a commit that referenced this issue May 10, 2021
@yilmi @damiencarol
Swap ptvsd for debugpy, ptvsd deprecated #4115 (#4322)
591e1be 
* Merging ptvsd into dev profile

* Documentation minor update and script cleanup

* Updating helm charts to remove mentioned of ptvsd

* Updating docker documentation

* Adding comments in code

* pep8 fixes

* Update docker-compose dev to get port from env

* Keeping debug profile, with same entrypoint as dev

* Documentation adjustments

* Setting variable in helmchart to enable debug

* Final docs changes

* Update helm/defectdojo/templates/django-deployment.yaml

Co-authored-by: Damien Carol <damien.carol@gmail.com>

* Update requirements.txt

Co-authored-by: Damien Carol <damien.carol@gmail.com>

* Bump chart version, and rename value

* Rebasing from dev

* pep8 fixes

* Rebasing

Co-authored-by: Damien Carol <damien.carol@gmail.com>
@yilmi
Copy link
Contributor

yilmi commented May 10, 2021

Can't close this task myself.

@valentijnscholten
Copy link
Member

fixed in dev/2.0.0

dsever pushed a commit to dsever/django-DefectDojo that referenced this issue May 18, 2021
@yilmi @damiencarol @dsever
Swap ptvsd for debugpy, ptvsd deprecated DefectDojo#4115 (DefectDojo#…
b61bbe1 
…4322)

* Merging ptvsd into dev profile

* Documentation minor update and script cleanup

* Updating helm charts to remove mentioned of ptvsd

* Updating docker documentation

* Adding comments in code

* pep8 fixes

* Update docker-compose dev to get port from env

* Keeping debug profile, with same entrypoint as dev

* Documentation adjustments

* Setting variable in helmchart to enable debug

* Final docs changes

* Update helm/defectdojo/templates/django-deployment.yaml

Co-authored-by: Damien Carol <damien.carol@gmail.com>

* Update requirements.txt

Co-authored-by: Damien Carol <damien.carol@gmail.com>

* Bump chart version, and rename value

* Rebasing from dev

* pep8 fixes

* Rebasing

Co-authored-by: Damien Carol <damien.carol@gmail.com>
madchap pushed a commit to madchap/django-DefectDojo that referenced this issue May 30, 2023
@yilmi @damiencarol @madchap
Swap ptvsd for debugpy, ptvsd deprecated DefectDojo#4115 (DefectDojo#…
1e8a644 
…4322)

* Merging ptvsd into dev profile

* Documentation minor update and script cleanup

* Updating helm charts to remove mentioned of ptvsd

* Updating docker documentation

* Adding comments in code

* pep8 fixes

* Update docker-compose dev to get port from env

* Keeping debug profile, with same entrypoint as dev

* Documentation adjustments

* Setting variable in helmchart to enable debug

* Final docs changes

* Update helm/defectdojo/templates/django-deployment.yaml

Co-authored-by: Damien Carol <damien.carol@gmail.com>

* Update requirements.txt

Co-authored-by: Damien Carol <damien.carol@gmail.com>

* Bump chart version, and rename value

* Rebasing from dev

* pep8 fixes

* Rebasing

Co-authored-by: Damien Carol <damien.carol@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@valentijnscholten @madchap @yilmi