-
Notifications
You must be signed in to change notification settings - Fork 30.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React-blessed types revamp #51189
React-blessed types revamp #51189
Conversation
Previously all types were `any` now for the most part they follow blessed.
Added NickHackman as a maintainer of @types/react-blesssed.
Wrong version of Typescript, interfaces started with "I".
Many interface types weren't used and removed generics that made more sense to be `unknown`.
- line - text - checkbox - button - textbox
👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings. Let’s review the numbers, shall we? These typings are for a version of react-blessed that doesn’t yet exist on master, so I’ve compared them with v0.3. Comparison details 📊
It looks like nothing changed too much. I won’t post performance data again unless it gets worse. |
@NickHackman what happens if we drop the |
No longer necessary that IntrinsicElements be prefixed to avoid name collisions with core React.
@Yomguithereal from my testing locally it works perfectly fine! That's a great quality of life improvement, going to work on ironing out more of the types. I'll update this comment with the ones I think are finished. One Question around Components [Excluding Styling, because it's finicky and less clear]:
|
Added documentation to a few elements and fixed some type issues and confusion with others.
Previously all types were
any
now for the most part they follow blessed. Still needs a lot more work to be completely correct.Please fill in this template.
Not the most meaningful, but this is a complete revamp of the previous type declarations which were very sparse.
npm test <package to test>
.Addressing: issue
@Yomguithereal whenever you have the chance would love some help filling in some of the edge cases. 👍 . Still very much a work in progress, going to work on ironing out each particular component in the coming days, just wanted to have some progress shown.