Remove the noqa and adjust test reference files #982
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As planned I removed the
flake8: noqa
from the top of the files that had it.I was surprised to see that the tests failed till I realized that the change in line number would affect the expected exception strings.
Oh well, a little bit of editing later and it's corrected.
I'd love to know how you make these
.txt
files with the expected output. I'm happy to document the process too if you want in CONTRIBUTING.For this time around though the editing may have been more straight forward.