More friendly host apis #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junyu0312
reviewed
Jan 2, 2024
crates/cli/src/app_builder.rs
Outdated
| &output_dir, | ||
| ), | ||
| Some(("setup", _)) => match host_mode { | ||
| HostMode::DEFAULT => exec_setup::<ExecutionArg, DefaultHostEnvBuilder>( |
There was a problem hiding this comment.
Why not use StandardEnvBuilder as default host? And I doubt that users can differentiate them by name.
There was a problem hiding this comment.
A better name might be standard --> default, default --> minimize, and then I can add a customize tag for those who would like to load env via a json file. But I think it can be done in a separate PR later.
junyu0312
reviewed
Jan 2, 2024
junyu0312
reviewed
Jan 2, 2024
crates/cli/src/exec.rs
Outdated
| circuit.exec_create_proof( | ||
| output_dir, | ||
| param_dir, | ||
| PKEY_CACHE.lock().as_mut().unwrap(), |
There was a problem hiding this comment.
PKEY_CACHE,K_PARAMS_CACHE should not expose to zkWasm?
junyu0312
reviewed
Jan 2, 2024
junyu0312
reviewed
Jan 2, 2024
junyu0312
reviewed
Jan 2, 2024
merge host ops into host-ops-1.6
junyu0312
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.